Skip to content

Optimize constant folding #9895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Sep 27, 2020

No description provided.

@sjrd
Copy link
Member

sjrd commented Sep 27, 2020

There are also a number of widenDealias.typeSymbol in the Scala.js backend (in JSCodeGen.scala), which should probably be changed as well.

@odersky
Copy link
Contributor Author

odersky commented Sep 27, 2020

@sjrd widenDealias is also removed in JSCodeGen.

@odersky
Copy link
Contributor Author

odersky commented Sep 27, 2020

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@sjrd
Copy link
Member

sjrd commented Sep 27, 2020

@sjrd widenDealias is also removed in JSCodeGen.

Oh right, it is. Somehow I had not realized that. Sorry.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/9895/ to see the changes.

Benchmarks is based on merging with master (8a9e0e9)

@odersky
Copy link
Contributor Author

odersky commented Sep 27, 2020

Seems to give consistent small wins between 1 and 2%

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 4cb9ee1 into scala:master Sep 29, 2020
@liufengyun liufengyun deleted the optimize-constfold branch September 29, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants