make an error message wording more idiomatic #9823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Sep 17, 2020
|
I haven't the chutzpah to contradict Seth. |
som-snytt
reviewed
Sep 18, 2020
|
The test failure on Windows seems unrelated to my changes. |
|
Unfortunately it has been not uncommon for tests to timeout on the Windows runner. Other recent examples: https://github.com/lampepfl/dotty/runs/1287511655?check_suite_focus=true https://github.com/lampepfl/dotty/runs/1281827713?check_suite_focus=true |
|
The delay induced by dotty-bot permits a late suggestion: |
smarter
approved these changes
Oct 23, 2020
|
somebody want to hit "merge" on this? I want my Hacktoberfest shirt! |
|
rerunning the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't say "has not the" in English
the fix I've chosen is to change "has" to "is", but if someone feels I've damaged the meaning while improving the grammar, I could go with "doesn't have the same kind" instead. lmk