Remove Reflect.Context from methods that do not require it #9807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
remove-reflect-context-where-it-is-not-needed
branch
from
4052a1f to
5986625
Compare
The Context only tracks the current owner. Most methods do not care implicilty about the current owner and can use the rootContext directly.
nicolasstucki
force-pushed
the
remove-reflect-context-where-it-is-not-needed
branch
from
5986625 to
301b9ba
Compare
liufengyun
approved these changes
Sep 16, 2020
nicolasstucki
deleted the
remove-reflect-context-where-it-is-not-needed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Context only tracks the current owner. Most methods do not care implicitly about the current owner and can use the
rootContextdirectly.