Skip to content

Rename methods on FreshContext to make mutation obvious and avoid name clashes with methods in Context #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rename methods on FreshContext to make mutation obvious and avoid name clashes with methods in Context #98

wants to merge 1 commit into from

Conversation

DarkDimius
Copy link
Contributor

No description provided.

@DarkDimius
Copy link
Contributor Author

@odersky @gzm0 please review

@gzm0
Copy link
Contributor

gzm0 commented Mar 26, 2014

I was thinking of the same. Although withXX is commonly used in builders, FreshContext is (strictly speaking) not a builder. Therefore set does seem more appropriate.

@gzm0
Copy link
Contributor

gzm0 commented Mar 26, 2014

LGTM

@DarkDimius DarkDimius mentioned this pull request Mar 26, 2014
Closed
@odersky
Copy link
Contributor

odersky commented Mar 26, 2014

LGTM. Conflicts with the fix/phases-etc pull request so it would be best if the same person closes both.

@DarkDimius
Copy link
Contributor Author

closed in favour of #97

@DarkDimius DarkDimius closed this Mar 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkDimius @gzm0 @odersky