Skip to content

Improve scalatest macro implementation #9750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2020
Merged

Improve scalatest macro implementation #9750

merged 1 commit into from
Sep 16, 2020
+1 −1

Conversation

nicolasstucki
Copy link
Contributor

Based on #9744

@nicolasstucki nicolasstucki self-assigned this Sep 8, 2020
@nicolasstucki nicolasstucki force-pushed the improve-scalatest-macro-implementation branch from b819291 to b9010e1 Compare September 15, 2020 15:35
@nicolasstucki nicolasstucki marked this pull request as ready for review September 16, 2020 08:40
liufengyun
liufengyun approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice refactoring 👍

@nicolasstucki nicolasstucki merged commit cbedf64 into scala:master Sep 16, 2020
@nicolasstucki nicolasstucki deleted the improve-scalatest-macro-implementation branch September 16, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun