Remove Reflection.TypeOrBounds abstraction #9706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
remove-reflect-TypeOrBounds
branch
5 times, most recently
from
67f118b to
9c09b42
Compare
* Align with TASTy format
* Make it simpler to handle types with the reflection API
* Remove ParamInfo from LambdaType (it was unused)
This abstraction is there for historical reasons only, from the time when there was split between TypeTree, TypeBoundsTree and Tree. This distinction is no longer in the API and the types should follow the same design.
Migration help: If there match on `Type` that matched agaist a `TypeOrBound`
```scala
def f(t: TypeOrBound) =
t match
case t: Type =>
...
```
The cases for `TypeBounds` and `NoPrefix` should be added before the `Type` test
```scala
def f(t: Type) =
t match
case t: TypeBounds =>
case NoPrefix() =>
case t => // t: Type
...
```
nicolasstucki
force-pushed
the
remove-reflect-TypeOrBounds
branch
from
9c09b42 to
6872bdb
Compare
|
The main change can be observed here https://github.com/lampepfl/dotty/pull/9706/files#diff-9f4835a5a317f5979ed21ebcaf830c33R73-R92 |
liufengyun
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This abstraction is there for historical reasons only, from the time when there was split between TypeTree, TypeBoundsTree and Tree. This distinction is no longer in the API and the types should follow the same design.
Migration help
If there match on
Typethat matched agaist aTypeOrBoundThe cases for
TypeBoundsandNoPrefixshould be added before theTypetestThen reflector. Those cases might not be needed in most situations.