Skip to content

Improve cast failure message #9698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2020
Merged

Improve cast failure message #9698

merged 1 commit into from
Sep 2, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Sep 1, 2020 •
edited
Loading

I noticed we are missing this type while debugging some code that crashed at a bad cast.

@nicolasstucki nicolasstucki self-assigned this Sep 1, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review September 2, 2020 08:34
liufengyun
liufengyun approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit ecfdd11 into scala:master Sep 2, 2020
@liufengyun liufengyun deleted the improve-cast-failure-message branch September 2, 2020 11:38
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @liufengyun @Kordyjan