Skip to content

Performance tweaks #9638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 26, 2020
Merged

Performance tweaks #9638

merged 5 commits into from
Aug 26, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Aug 25, 2020

Some performance tweaks for warm methods. Essentially, try to test cheap conditions that narrow the possibilities
first and avoid some allocations.

Use simple test firsts in Import#selection (where not finding
something is the norm), and avoid re-selection of `ctx.owner`.
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit 2e58a66 into scala:master Aug 26, 2020
@odersky odersky deleted the optimze-conditions branch August 26, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants