-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #9473: Add test #9565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9473: Add test #9565
Conversation
Should the example in https://dotty.epfl.ch/docs/reference/contextual/derivation.html also be updated? |
The example there actually works well, I mean the |
@OlivierBlanvillain I'm not sure if it is the best way to do it. Could you have a look? |
These changes make sense, now that we have by name implicits they are cannonical way to deal with recursive data types. I don't see a reason not to update the example from the doc, the updated version is more robust and having it that way in the docs can only help! |
fcb7b27
to
ee4b125
Compare
test performance please |
performance test scheduled: 11 job(s) in queue, 1 running. |
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9565/ to see the changes. Benchmarks is based on merging with master (6149e92) |
The last commit can be dropped, since equivalent code is now merged in master. |
Fix #9473: Add test