Skip to content

Fix #9473: Add test #9565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Fix #9473: Add test #9565

merged 2 commits into from
Aug 20, 2020

Conversation

liufengyun
Copy link
Contributor

Fix #9473: Add test

@smarter
Copy link
Member

smarter commented Aug 14, 2020

Should the example in https://dotty.epfl.ch/docs/reference/contextual/derivation.html also be updated?

@liufengyun
Copy link
Contributor Author

liufengyun commented Aug 14, 2020

Should the example in https://dotty.epfl.ch/docs/reference/contextual/derivation.html also be updated?

The example there actually works well, I mean the Opt example. It does not work with the example Tree in the report.

@liufengyun
Copy link
Contributor Author

@OlivierBlanvillain I'm not sure if it is the best way to do it. Could you have a look?

@OlivierBlanvillain
Copy link
Contributor

These changes make sense, now that we have by name implicits they are cannonical way to deal with recursive data types.

I don't see a reason not to update the example from the doc, the updated version is more robust and having it that way in the docs can only help!

@liufengyun liufengyun force-pushed the fix-9473 branch 2 times, most recently from fcb7b27 to ee4b125 Compare August 20, 2020 13:32
@liufengyun
Copy link
Contributor Author

test performance please

@dottybot
Copy link
Member

performance test scheduled: 11 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/9565/ to see the changes.

Benchmarks is based on merging with master (6149e92)

@odersky
Copy link
Contributor

odersky commented Aug 20, 2020

The last commit can be dropped, since equivalent code is now merged in master.

@liufengyun liufengyun merged commit 1431be2 into scala:master Aug 20, 2020
@liufengyun liufengyun deleted the fix-9473 branch August 20, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeclass derivation from docs example results in stack overflow
5 participants