Fix the first example under "Parameter Types of Function Values" #9519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example had two issues: 1. It used `f` both as the name of the method and the argument. While it compiled, it seemed unnecessarily confusing to overload that name. So I changed the name of the function argument to +f2+. 2. The example failed to compile because it passed +String+ and +String => Int+ arguments. I fixed the example and added another one example for +Int+ and +Int => Int+ arguments.
dottybot
reviewed
Aug 8, 2020
liufengyun
reviewed
Aug 14, 2020
There was a problem hiding this comment.
Thanks @deanwampler 👍
Don't forget to sign the CLA: https://www.lightbend.com/contribute/cla/scala
| def f(x: Int, f2: Int => Int) = f2(x) | ||
| def f(x: String, f2: String => String) = f2(x) | ||
| f("a", _.toUpperCase) | ||
| f(2, _ * 2) | ||
| ``` |
There was a problem hiding this comment.
What about using m for methods and keep f for function parameters?
odersky
approved these changes
Aug 18, 2020
|
Thanks for the fix, Dean! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example had two issues:
fboth as the name of the method and the argument. While it compiled, it seemed unnecessarily confusing to overload that name. So I changed the name of the function argument to +f2+.