Consistent override checking #9477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 7964d17, `OverridingPairs.Cursor#matches` was changed to use Denotations#matches instead of Types#matches to make the override check more precise, but the same was not done in `RefChecks#checkAllOverrides#hasMatchingSym#isSignatureMatch`, which lead to inconsistencies: in the added testcase, the definition of `foo` in `B` doesn't override anything, but because OverridingPairs and RefChecks disagreed on what an override was, that did not produce any error.
smarter
force-pushed
the
fix-override-check
branch
from
91e3420 to
32a10d5
Compare
odersky
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7964d17,
OverridingPairs.Cursor#matcheswas changed to use Denotations#matchesinstead of Types#matches to make the override check more precise, but
the same was not done in
RefChecks#checkAllOverrides#hasMatchingSym#isSignatureMatch, whichlead to inconsistencies: in the added testcase, the definition of
fooin
Bdoesn't override anything, but because OverridingPairs andRefChecks disagreed on what an override was, that did not produce any
error.