Drop old extension method syntax #9476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
drop-old-extension
branch
from
5d6b35b to
899c71a
Compare
odersky
force-pushed
the
drop-old-extension
branch
from
899c71a to
f61b4e9
Compare
|
I give up. Can somebody else take this over please? |
|
I'll have a look at it |
odersky
force-pushed
the
drop-old-extension
branch
from
7990732 to
ce9717b
Compare
|
@nicolasstucki I think I have switched branches by accident. Trying again. |
|
There was one extension left using the old syntax. Now it should be fine. |
nicolasstucki
approved these changes
Aug 17, 2020
|
@nicolasstucki It seems something with the pushing of xml-interpolator went wrong. Did you push the new commits in that submodule. |
|
I pushed the commit and restarted the tests |
|
Good to get this over the finish line! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.