Better handling of ctrl-c while the compiler is running #9429
+22
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the compiler tried its best to continue working after
ctrl-c, which usually resulted in a flood of error messages. This commit
takes inspiration from scala/scala#6479 to
handle ClosedByInterruptException and InterruptedException gracefully
and avoid this.
Note that the Scala 2 PR goes further: it checks
Thread.interrupted()
to set a global
cancelled
flag (Should we do the same with ourRun#isCancelled
?) and it also catches InterruptedException at thetop-level so that ctrl-c does not end up printing a stacktrace, but this
is beyond what I have the time to look at currently.