Skip to content

Fix #9306: Don't allow inline functions with errors in bodies #9319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jul 8, 2020

This was done previously only for one scenario: where a lazy inline body
was updated. But there were two more scenarios where errors could creep
in before the lazy annotation was forced.

@odersky odersky changed the title Fix #9308: Don't allow inline functions with errors in bodies Fix #9309: Don't allow inline functions with errors in bodies Jul 8, 2020
@odersky odersky changed the title Fix #9309: Don't allow inline functions with errors in bodies Fix #9306: Don't allow inline functions with errors in bodies Jul 8, 2020
@nicolasstucki nicolasstucki linked an issue Jul 8, 2020 that may be closed by this pull request
@odersky odersky requested a review from nicolasstucki July 8, 2020 15:56
This was done previously only for one scenario: where a lazy inline body
was updated. But there were two more scenarios where errors could creep
in before the lazy annotation was forced.
@nicolasstucki nicolasstucki merged commit cfc1c69 into scala:master Jul 16, 2020
@nicolasstucki nicolasstucki deleted the fix-#9308 branch July 16, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inlined += on a private var leads to a crash
2 participants