Add upickle to the community build #9245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatoliykmetyuk
force-pushed
the
upickle-cb
branch
from
01137b3 to
fb1b290
Compare
anatoliykmetyuk
commented
Jun 30, 2020
community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala
Outdated
Show resolved
Hide resolved
anatoliykmetyuk
force-pushed
the
upickle-cb
branch
from
a27187d to
385aac0
Compare
nicolasstucki
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally. Upickle's test suite was giving me so much trouble that I disabled it for Dotty in its entirety and wrote my own one. It seems to work against that simple test suite, maybe we'll catch more bugs when porting further projects that depend on upickle.