Skip to content

Move all macro tests into their folders #9238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2020
Merged

Move all macro tests into their folders #9238

merged 1 commit into from
Jun 24, 2020

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jun 24, 2020 •
edited
Loading

This way it will be possible to run all macro tests using dotty-bootstrapped/testCompilation macros. It will also take a bit of load off the CI.

@nicolasstucki nicolasstucki requested a review from liufengyun June 24, 2020 15:02
liufengyun
liufengyun approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We have done this for several language features, I think it is a good practice.

@nicolasstucki nicolasstucki merged commit 3a4f2ee into scala:master Jun 24, 2020
@nicolasstucki nicolasstucki deleted the move-macro-tests branch June 24, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun