Fix #9227: Do not suspend REPL compilation unit #9232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Jun 25, 2020
allanrenucci
approved these changes
Jun 25, 2020
| @@ -146,7 +146,7 @@ class ReplCompiler extends Compiler { | |||
| val objectTermName = ctx.source.file.toString.toTermName | |||
| objectNames.update(defs.state.objectIndex, objectTermName) | |||
|
|
|||
| val unit = CompilationUnit(ctx.source) | |||
| val unit = new ReplCompilationUnit(ctx.source) | |||
There was a problem hiding this comment.
Nit: I would use an anonymous class
Suggested change
| val unit = new ReplCompilationUnit(ctx.source) | |
| val unit = new CompilationUnit(ctx.source) { | |
| override def isSuspendable: Boolean = false | |
| } |
There was a problem hiding this comment.
I wanted to make it possible to identify a REPL compilation unit simply. I remember seeing places where we identify them by the name of the file which we could simplify with this scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.