Fix documentation #9219
Merged
Fix documentation #9219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `reflect` function was renamed to `to`, and its references need update
dottybot
reviewed
Jun 22, 2020
nicolasstucki
approved these changes
Jun 22, 2020
nicolasstucki
suggested changes
Jun 22, 2020
|
|
||
| ```scala | ||
| def reflect[T: Type, U: Type](f: Expr[T] => Expr[U]): Expr[T => U] = | ||
| def to[T: Type, R: Type](f: Expr[T] => Expr[R]): Expr[T => R] = |
There was a problem hiding this comment.
Suggested change
| def to[T: Type, R: Type](f: Expr[T] => Expr[R]): Expr[T => R] = | |
| def to[T: Type, R: Type](f: Expr[T] => Expr[R])(using QuoteContext): Expr[T => R] = |
| '{ (x: T) => ${ f('x) } } | ||
| ``` | ||
| would be rewritten to | ||
| ```scala | ||
| def reflect[T: Type, U: Type](f: Expr[T] => Expr[U]): Expr[T => U] = | ||
| def to[T: Type, R: Type](f: Expr[T] => Expr[R]): Expr[T => R] = |
There was a problem hiding this comment.
Suggested change
| def to[T: Type, R: Type](f: Expr[T] => Expr[R]): Expr[T => R] = | |
| def to[T: Type, R: Type](f: Expr[T] => Expr[R])(using QuoteContext): Expr[T => R] = |
|
@nicolasstucki The suggested changes are included. |
nicolasstucki
approved these changes
Jun 22, 2020
|
Thank you @ShapelessCat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
reflectfunction was renamed toto, and its references needupdate