Skip to content

Remove unseal from compiler interface #9192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

Implement unseal in userspace

@nicolasstucki nicolasstucki force-pushed the remove-unseal-from-compiler-interface branch 4 times, most recently from d0e6975 to 89a6f80 Compare June 18, 2020 07:27
Implement `unseal` in userspace
@nicolasstucki nicolasstucki force-pushed the remove-unseal-from-compiler-interface branch from 89a6f80 to 2874610 Compare June 18, 2020 07:33
@nicolasstucki nicolasstucki self-assigned this Jun 18, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review June 18, 2020 11:24
@nicolasstucki
Copy link
Contributor Author

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/9192/ to see the changes.

Benchmarks is based on merging with master (ddc4dc9)

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit bf478d0 into scala:master Jun 18, 2020
@nicolasstucki nicolasstucki deleted the remove-unseal-from-compiler-interface branch June 18, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants