Skip to content

Fix #7294: Add limit on trees that can be inlined in a compilation unit #9163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Jun 11, 2020

Whit this change, executing testCompilation tests/neg/i7294 takes 10s. Before it timed out or ran out of memory.

@nicolasstucki
Copy link
Contributor Author

We do need both the inline depth check. The count does not grow fast enough to avoid a StackOverflow.

@nicolasstucki nicolasstucki self-assigned this Jun 11, 2020
@nicolasstucki nicolasstucki linked an issue Jun 11, 2020 that may be closed by this pull request
@nicolasstucki nicolasstucki marked this pull request as ready for review June 11, 2020 17:01
@nicolasstucki nicolasstucki removed their assignment Jun 11, 2020
@nicolasstucki nicolasstucki requested a review from odersky June 11, 2020 17:02
@nicolasstucki
Copy link
Contributor Author

The current limit was chosen to allow all the current tests to compile out of the box.

@odersky odersky assigned nicolasstucki and unassigned odersky Jun 14, 2020
@nicolasstucki nicolasstucki merged commit bf3d60a into scala:master Jun 15, 2020
@nicolasstucki nicolasstucki deleted the fix-#7294 branch June 15, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop with OutOfMemory error while inlining givens
2 participants