Fix #9132: Align with Scala 2's handling of () infix arguments #9137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A right argument of an infix operation is kept as an empty tuuple, instead of being desugared to an empty parameter list. The most involved part of the change was getting decent error messages, since it required propagating the information that an apply is an infix all the way into application checking. Hopefully, we can profit from the change when we drop auto-tupling, since then similar info will be needed for error messages in more situations.
smarter
reviewed
Jun 9, 2020
liufengyun
approved these changes
Jun 9, 2020
| def setUsingApply() = { putAttachment(untpd.ApplyGiven, ()); this } | ||
| def setUsingApply() = | ||
| putAttachment(untpd.ApplyGiven, ()) | ||
| this |
There was a problem hiding this comment.
A conceptual question: if Infix and Using are mutually exclusive, would it be better to use attachment for Infix as well to avoid creating the class InfixApply? Something like:
def setApplyKind(kind: ApplyKind) =
putAttachment(untpd.ApplyKind, kind)
this
def applyKind: ApplyKind =
attachmentOrElse(untpd.ApplyKind, ApplyKind.Regular)There was a problem hiding this comment.
Yes, I think that might be better. I'll try that out.
Co-authored-by: Guillaume Martres <smarter@ubuntu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A right argument of an infix operation is kept as an empty tuple, instead
of being desugared to an empty parameter list.
The most involved part of the change was getting decent error messages, since
it required propagating the information that an apply is an infix all the way
into application checking. Hopefully, we can profit from the change when
we drop auto-tupling, since then similar info will be needed for error
messages in more situations.