Ensure names used in signatures are stable #9133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signatures should not change before erasure, but some phases before erasure can change the owner of a definition, which can change their full name and therefore any signature which refers to these names. This commit fixes this by ensuring we always use the initial symbol to compute signatures before erasure. The check for signature consistency in TreeChecker was also improved as it wasn't able to catch this issue before due to signature caching hiding the issue.
|
test performance please |
|
performance test scheduled: 6 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/9133/ to see the changes. Benchmarks is based on merging with master (fa84627) |
odersky
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signatures should not change before erasure, but some phases before
erasure can change the owner of a definition, which can change their
full name and therefore any signature which refers to these names.
This commit fixes this by ensuring we always use the initial symbol to
compute signatures before erasure. The check for
signature consistency in TreeChecker was also improved as it wasn't able
to catch this issue before due to signature caching hiding the issue.