Fix #8839: Only warn if TASTy is not in sync with classfile #9125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
Jun 8, 2020
|
I think I was running standalone. |
odersky
approved these changes
Jun 8, 2020
|
I also hit it in stand alone. Also reproduced it this way. |
smarter
approved these changes
Jun 8, 2020
compiler/src/dotty/tools/dotc/core/classfile/ClassfileParser.scala
Outdated
Show resolved
Hide resolved
If they are not in sync, we warn and suggest to clean. We assume that the TASTy is up to date (arbitrary choise) and load it regardless. This way we are resiliant to the failiure if the loaded class API did not change or did not have an impact on the code we are compiling.
jjudd
added a commit
to jjudd/scala
that referenced
this pull request
Sep 11, 2021
This matches the behavior in Scala, which was changed in this pull request: scala/scala3#9125 It was changed as a result of this issue: scala/scala3#8839 The commit message from the Scala 3 fix is as follows: "Only warn if TASTy is not in sync with classfile If they are not in sync, we warn and suggest to clean. We assume that the TASTy is up to date (arbitrary choise) and load it regardless. This way we are resiliant to the failiure if the loaded class API did not change or did not have an impact on the code we are compiling."
jjudd
added a commit
to jjudd/scala
that referenced
this pull request
Sep 11, 2021
This matches the behavior in Scala, which was changed in this pull request: scala/scala3#9125 It was changed as a result of this issue: scala/scala3#8839 The commit message from the Scala 3 fix is as follows: > Only warn if TASTy is not in sync with classfile > > If they are not in sync, we warn and suggest to clean. > We assume that the TASTy is up to date (arbitrary choise) and load it regardless. > This way we are resiliant to the failiure if the loaded class API did not change or > did not have an impact on the code we are compiling."
jjudd
added a commit
to jjudd/scala
that referenced
this pull request
Sep 11, 2021
This updates Scala 2.13 to match the current behavior in Scala 3 when TASTy is not in sync with classfile, which is to print a warning and suggest cleaning instead of erroring. The same change for Scala 3 happened in the following pull request: scala/scala3#9125 The Scala 3 change was made as a result of the following issue: scala/scala3#8839 The commit message from the Scala 3 fix is as follows: > Only warn if TASTy is not in sync with classfile > > If they are not in sync, we warn and suggest to clean. > We assume that the TASTy is up to date (arbitrary choise) and load it regardless. > This way we are resiliant to the failiure if the loaded class API did not change or > did not have an impact on the code we are compiling."
lrytz
pushed a commit
to jjudd/scala
that referenced
this pull request
Sep 14, 2021
This updates Scala 2.13 to match the current behavior in Scala 3 when TASTy is not in sync with classfile, which is to print a warning and suggest cleaning instead of erroring. The same change for Scala 3 happened in the following pull request: scala/scala3#9125 The Scala 3 change was made as a result of the following issue: scala/scala3#8839 The commit message from the Scala 3 fix is as follows: > Only warn if TASTy is not in sync with classfile > > If they are not in sync, we warn and suggest to clean. > We assume that the TASTy is up to date (arbitrary choise) and load it regardless. > This way we are resiliant to the failiure if the loaded class API did not change or > did not have an impact on the code we are compiling."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If they are not in sync, we warn and suggest to clean.
We assume that the TASTy is up to date (arbitrary choise) and load it regardless.
This way we are resiliant to the failiure if the loaded class API did not change or
did not have an impact on the code we are compiling.