Skip to content

Fix #8997: Support multiple contextual parameter blocks on unapply #9003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2020
Merged

Fix #8997: Support multiple contextual parameter blocks on unapply #9003

merged 3 commits into from
May 25, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki linked an issue May 19, 2020 that may be closed by this pull request
Unapply with several given argument lists #8997
Closed
@nicolasstucki nicolasstucki self-assigned this May 19, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review May 19, 2020 13:07
@nicolasstucki nicolasstucki removed their assignment May 19, 2020
@nicolasstucki nicolasstucki requested a review from odersky May 19, 2020 13:07
@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented May 19, 2020 •
edited
Loading

Alternatives with a redefinition of UnApply.

  • case class UnApply(fun: Tree, implicitss: List[List[Tree]], patterns: List[Tree])
  • case class UnApply(fun: Tree, patterns: List[Tree]) and use Apply(Apply(UnApply(fun, patterns), implicits1), implicits2)
  • case class UnApply(fun: Tree, patterns: List[Tree]) and use UnApply(Apply(Apply(Apply(unapp, List(dummy)), implicits1), implicits2), patterns)

odersky
odersky reviewed May 24, 2020
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@odersky odersky assigned nicolasstucki and unassigned odersky May 24, 2020
@nicolasstucki nicolasstucki merged commit ab9bf66 into scala:master May 25, 2020
@nicolasstucki nicolasstucki deleted the fix-#8997 branch May 25, 2020 07:15
@adampauls adampauls mentioned this pull request Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky left review comments

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unapply with several given argument lists
2 participants
@nicolasstucki @odersky