Skip to content

Fix #8945: Support macro bundles #8964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2020
Merged

Fix #8945: Support macro bundles #8964

merged 1 commit into from
May 18, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this May 12, 2020
@nicolasstucki nicolasstucki requested a review from bishabosha May 12, 2020 15:56
@nicolasstucki nicolasstucki marked this pull request as ready for review May 12, 2020 19:41
@nicolasstucki nicolasstucki linked an issue May 16, 2020 that may be closed by this pull request
Support Scala 2 Macro bundle definitions #8945
Closed
bishabosha
bishabosha approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works perfectly reading the tasty from scala 2 for the example in the issue

@nicolasstucki nicolasstucki merged commit 63a5a62 into scala:master May 18, 2020
@nicolasstucki nicolasstucki deleted the fix-##8945 branch May 18, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees

@bishabosha bishabosha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Scala 2 Macro bundle definitions
2 participants
@nicolasstucki @bishabosha