Skip to content

Rename QuoteContext.NestedContext to QuoteContext.Nested #8938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2020
Merged

Rename QuoteContext.NestedContext to QuoteContext.Nested #8938

merged 1 commit into from
May 11, 2020

Conversation

nicolasstucki
Copy link
Contributor

The Context suffix is redundant and a bit long. We change the name to make it shorter and simpler to use.

@nicolasstucki nicolasstucki self-assigned this May 11, 2020
@nicolasstucki nicolasstucki requested a review from liufengyun May 11, 2020 06:18
liufengyun
liufengyun approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun marked this pull request as ready for review May 11, 2020 07:06
@nicolasstucki nicolasstucki merged commit f511fb2 into scala:master May 11, 2020
@nicolasstucki nicolasstucki deleted the rename-quotecontext-nested branch May 11, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun