Support command prefixes in REPL #8901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. `:q` or `:qu` instead of `:quit`. If exactly one command matching the prefix is found, it is executed. If multiple matching commands are found, an error is shown. (Currently this is not possible, as each command starts with a different letter.)
dottybot
reviewed
May 7, 2020
They're in https://github.com/lampepfl/dotty/tree/master/compiler/test/dotty/tools/repl |
|
There's also scripted repl tests in https://github.com/lampepfl/dotty/tree/master/compiler/test-resources |
|
This closes #115 in the feature requests repl. |
smarter
requested changes
May 7, 2020
| matchingParsers match { | ||
| case Nil => UnknownCommand(cmd) | ||
| case f :: Nil => f(arg) | ||
| case _ => AmbiguousCommand(cmd) |
There was a problem hiding this comment.
Can you pass the list of matching commands here to make the error message more descriptive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
:qor:quinstead of:quit.If exactly one command matching the prefix is found, it is executed.
If multiple matching commands are found, an error is shown. (Currently this is not possible, as each command starts with a different letter.)
I've tested manually but couldn't find any automated tests for the REPL. Happy to write a test if someone can point me to the right place.Added a scripted test.