Fix #8749: Error on $ at the start of a name in quoted patterns #8771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would disallow them instead of warning. |
smarter
reviewed
Apr 22, 2020
nicolasstucki
force-pushed
the
fix-#8749
branch
2 times, most recently
from
1c2eb3b to
92f18b9
Compare
|
Actually def sourcePos: SourcePosition = source.atSpan(span) |
nicolasstucki
force-pushed
the
fix-#8749
branch
2 times, most recently
from
b6bf727 to
52023f1
Compare
nicolasstucki
force-pushed
the
fix-#8749
branch
from
52023f1 to
4d6f907
Compare
nicolasstucki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just part of the name.