Fix #8750: Strip opaque refinements when checking self type #8751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strip opaque refinements when checking that a class is instantiatable
smarter
approved these changes
Apr 20, 2020
| // Create a synthetic singleton type instance, and check whether | ||
| // it conforms to the self type of the class as seen from that instance. | ||
| val stp = SkolemType(tp) | ||
| val selfType = cls.asClass.givenSelfType.asSeenFrom(stp, cls) | ||
| val selfType = | ||
| cls.asClass.givenSelfType.stripOpaques.asSeenFrom(stp, cls) |
There was a problem hiding this comment.
Maybe stripOpaque should be a boolean parameter of givenSelfTypes ?
There was a problem hiding this comment.
I think it's safer to keep givenSelfType as is. It's really just when checking that we need to strip the refinements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip opaque refinements when checking that a class is instantiatable