Remove quoted name splices #8693
Merged
+39
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additionally, this feature does not provide any semantic meaning to the names hence it does not align with the quotes and splices abstractions. It is always possible to recover this name using reflection. |
liufengyun
approved these changes
Apr 8, 2020
| def rhsEnv = summon[Env] + (scrutinee.symbol -> pattern.symbol) | ||
| bindMatch && tpt1 =?= tpt2 && treeOptMatches(rhs1, rhs2)(using summon[Context], rhsEnv) | ||
| tpt1 =?= tpt2 && treeOptMatches(rhs1, rhs2)(using summon[Context], rhsEnv) |
There was a problem hiding this comment.
The pattern matching on definitions up to alpha-conversion 👍
nicolasstucki
force-pushed
the
remove-name-patterns
branch
from
f495ef1 to
95eeaef
Compare
|
We need to rebootstrap the compiler to have #8692 in the reference compiler. |
Alternatively, you could leave the definitions needed by the non-bootstrapped compiler in the library for now, or move them to |
nicolasstucki
force-pushed
the
remove-name-patterns
branch
from
95eeaef to
1d2ac5c
Compare
The current encoding of name splices is quite ad-hoc and intrusive. It changes the meaning of a name that starts with `$` which does not align with other kinds of splices. It also does not align with the names that may be shown by `Expr.show`.
nicolasstucki
force-pushed
the
remove-name-patterns
branch
from
1d2ac5c to
5c40b96
Compare
|
I kept the annotation for now as it is internal and will not change anything. I left a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current encoding of name splices is quite ad-hoc and intrusive. It changes the meaning
of a name that starts with
$which does not align with other kinds of splices. It also doesnot align with the names that may be shown by
Expr.show.Based on #8692.