Rename ctx values #8654
Merged
Rename ctx values #8654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
approved these changes
Apr 2, 2020
We would like to distinguish between `ctx` referring to an enclosing parameter and `ctx` referring to a field. This is so that we can at some point drop `ctx` as a parameter name and just use (using Context). The `ctx` would then go to an imported def in `Contexts`. But any other use of `ctx` does does not follow strict nesting discipline can then change meaning, so we should get these out of the way first.
New master checks for inherited symbols shadowing definitions, so it contained a number of changes where `ctx` in a map or an accumulator was renamed to `this.ctx`. All of these broke because we renamed `ctx` in map to `mapCtx`. Before, all these occurrences of `ctx` silently rebound in this PR to the enclosing `ctx` which is mostly OK, since the two contexts tend to be the same, but could also be wrong. So, the additional check has already apid for itself in increased robustness of refactorings!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to distinguish between
ctxreferring to an enclosing parameterand
ctxreferring to a field. This is so that we can at some point dropctxas a parameter name and just use (using Context). Thectxwould thengo to an imported def in
Contexts. But any other use ofctxdoes does notfollow strict nesting discipline can then change meaning, so we should
get these out of the way first.