LazyAnnotation: avoid unnecessary memory leaks #8620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
annot-leak
branch
2 times, most recently
from
c88e224 to
e185d76
Compare
When a deferred annotation has been completed, let the completer closure be garbage-collected to avoid potential leaks.
And address the TODO comment by adding an apply method that takes a `Context ?=> Tree`. Also add `Annotation#isEvaluating`, previously `LazyBodyAnnotation#isEvaluated` was also returning true when evaluation was started but not finished which was confusing.
odersky
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a deferred annotation has been completed, let the completer closure
be garbage-collected to avoid potential leaks.