Turn mismatch given errors into given not found errors #8607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Mar 25, 2020
julienrf
force-pushed
the
replace-implicit-mismatch-with-implicit-not-found
branch
from
498ed16 to
caa9c36
Compare
Fixes #8053 When a given candidate turns out to not be applicable we used to report that there is a mismatch between the candidate type and the expected type. However, I believe that if there is a type mismatch, then the candidate should not be a candidate in the first place. I’ve changed the failure to be a `NoMatchingImplicitsFailure` instead of a mismatch. Hopefully this won’t have a negative impact. I’ve added a couple of tests that used to report a mismatch for the "candidate" `$conforms[Nothing]` and they now report that no given could be found. One existing test was broken by my changes. This test was very similar to the ones described in #8053, so I’ve changed the test expectation.
julienrf
force-pushed
the
replace-implicit-mismatch-with-implicit-not-found
branch
from
caa9c36 to
da29c0a
Compare
|
Please don't create branches in the lampepfl/dotty repository when making a PR, instead make a branch in your own fork. |
|
Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8053
When a given candidate turns out to not be applicable we used to report that
there is a mismatch between the candidate type and the expected type.
However, I believe that if there is a type mismatch, then the candidate should
not be a candidate in the first place.
I’ve changed the failure to be a
NoMatchingImplicitsFailureinstead of a mismatch.Hopefully this won’t have a negative impact. I’ve added a couple of tests that used to
report a mismatch for the "candidate"
$conforms[Nothing]and they now report thatno given could be found. One existing test was broken by my changes. This test was
very similar to the ones described in #8053, so I’ve changed the test expectation.