Fix #8569: Better error message for erroneous creator applications #8584
Conversation
Don't just fall-back to say "not a member".
|
Based on #8583 |
Give some context why an immutable path is required, and explain what an immutable path is.
Let the class itself worry about how to display that name, and means we can compare that name in `saysNotFound` without having to convert it to a String.
There was a problem hiding this comment.
Really nice errors! I've pushed an extra commit to make MissingIdent take a Name instead of a String to avoid the use of Name#toString. In #8569 I suggested we could also automatically stabilize prefixes of constructor calls to avoid the error, what's your opinion on that ?
|
I considered auto-stabilization, but in the end did not follow through. The problem is that you might generate a temporary variable that then gives a mysterious error message when you need to apply avoidance later. Also, it works only in some cases. I.e. works for new, but not for other types or class parents. I believe the issue is best discussed separately. If we talk about auto-stabilization, we should also consider paths in patterns and in imports. |
|
This PR caused significant performance regression. |
|
Wow, that's amazing. I guess it's because it's forcing error message contents to see what's in it. |
Don't just fall-back to say "not a member".