Skip to content

Simplify quoted.autolift import #8546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/docs/reference/metaprogramming/macros.md
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ That is, the `showExpr` method converts its `Expr` argument to a string (`code`)
the result back to an `Expr[String]` using `Expr.apply`.

**Note**: Lifting `String` to `Expr[String]` using `Expr(code)` can be omitted by importing an implicit
conversion with `import scala.quoted.autolift.given`. The programmer is able to
conversion with `import scala.quoted.autolift`. The programmer is able to
declutter slightly the code at the cost of readable _phase distinction_ between
stages.

Expand Down
7 changes: 2 additions & 5 deletions library/src/scala/quoted/autolift.scala
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
package scala.quoted

/** Enable implicit conversion from a term of type `T` to an expression of type `Expr[T]` */
object autolift {
/** Implicit conversion from a term of type `T` to an expression of type `Expr[T]` */
given autoToExpr[T](using Liftable[T], QuoteContext) as Conversion[T, Expr[T]] = Expr(_)
}
/** Implicit conversion from a term of type `T` to an expression of type `Expr[T]` */
given autolift[T](using Liftable[T], QuoteContext) as Conversion[T, Expr[T]] = Expr(_)
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/disabled/run/xml-interpolation-3/XmlQuote_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import scala.quoted._
import scala.tasty.Tasty
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

import scala.language.implicitConversions

Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/i6432/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift


object Macro {
Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/i6432b/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift


object Macro {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift


object E {
Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/inline-tuples-1/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {
def tup1(tup: Expr[Tuple1[Int]]) (using QuoteContext): Expr[Int] = tup.unliftOrError.productIterator.map(_.asInstanceOf[Int]).sum
Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/quote-interpolator-core-old.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

// This test checks the correct interpretation of the inlined value class

Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/quote-macro-splice.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Test {

Expand Down
2 changes: 1 addition & 1 deletion tests/neg-macros/splice-in-top-level-splice-1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Foo {
inline def foo(): Int = ${bar(${x})} // error
Expand Down
2 changes: 1 addition & 1 deletion tests/neg-staging/quote-run-in-macro-1/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import scala.quoted._
import scala.quoted.staging._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/pending/run/tasty-comments/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift


object Macros {
Expand Down
2 changes: 1 addition & 1 deletion tests/pos-macros/i6803b/Macro_1.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package blah

import scala.language.implicitConversions
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object AsObject {
final class LineNo(val lineNo: Int)
Expand Down
2 changes: 1 addition & 1 deletion tests/pos-macros/quote-nested-object/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macro {

Expand Down
2 changes: 1 addition & 1 deletion tests/pos-staging/quote-0.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import scala.quoted._
import scala.quoted.staging._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Foo {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Foo {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/f-interpolation-1/FQuote_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

import scala.language.implicitConversions

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/f-interpolator-neg/Macros_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift


import scala.language.implicitConversions
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i4734/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import scala.annotation.tailrec
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {
inline def unrolledForeach(seq: IndexedSeq[Int], f: => Int => Unit, inline unrollSize: Int): Unit = // or f: Int => Unit
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i4735/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.annotation.tailrec
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

import scala.quoted._

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i5119/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macro {
class StringContextOps(sc: => StringContext) {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i5119b/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift


object Macro {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i5188a/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Lib {
inline def sum(inline args: Int*): Int = ${ impl('args) }
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/i6518/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/inferred-repeated-result/test_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
object Macros {
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

inline def go[T](inline t: T) = ${ impl('t) }
def impl[T](expr: Expr[T])(using qctx: QuoteContext) : Expr[Unit] = {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/inline-option/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/inline-tuples-1/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {
def tup1(tup: Expr[Tuple1[Int]]) (using QuoteContext): Expr[Int] = tup.unliftOrError.productIterator.map(_.asInstanceOf[Int]).sum
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/inline-tuples-2/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/inline-varargs-1/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {
def sum(nums: Expr[Int]*) (using QuoteContext): Expr[Int] = nums.map(_.unliftOrError).sum
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-force/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

case class Location(owners: List[String])

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-impure-by-name/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift


class Index[K, Keys](val index: String) extends AnyVal {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-inline-function/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-matching-optimize-1/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macro {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-matching-optimize-2/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

import scala.tasty.Reflection

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-matching-optimize-3/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

import scala.tasty.Reflection

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-simple-macro/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {
inline def foo(inline i: Int, dummy: Int, j: Int): Int = ${ bar('i, 'j) }
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/quote-unrolled-foreach/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import scala.annotation.tailrec
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macro {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-argument-tree-1/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-custom-show/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift


object Macros {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-definitions-1/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-eval/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-extractors-1/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-extractors-2/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-extractors-3/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import scala.quoted._

import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift



Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-extractors-types/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macros {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object SourceFiles {

Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-getfile/Macro_1.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift


object SourceFiles {
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-indexed-map/quoted_1.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

import scala.quoted._
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

class MyMap[Keys](private val underlying: Array[Int]) extends AnyVal {
def get[K <: String](implicit i: Index[K, Keys]): Int = underlying(i.index)
Expand Down
2 changes: 1 addition & 1 deletion tests/run-macros/tasty-interpolation-1/Macro.scala
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

import scala.quoted._
import scala.language.implicitConversions
import scala.quoted.autolift.{given _}
import scala.quoted.autolift

object Macro {

Expand Down
Loading