Skip to content

Fix description of -Yno-kind-polymorphism #8432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Conversation

ybasket
Copy link
Contributor

@ybasket ybasket commented Mar 3, 2020

As the flag indicates with the no- and the docs (https://dotty.epfl.ch/docs/reference/other-new-features/kind-polymorphism.html) say, the compiler flag disables kind polymorphism, not enables it.

As the flag indicates with the `no-` and the docs (https://dotty.epfl.ch/docs/reference/other-new-features/kind-polymorphism.html) say, the compiler flag disables kind polymorphism, not enables it.
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@ybasket ybasket requested a review from dottybot March 3, 2020 20:41
@ybasket
Copy link
Contributor Author

ybasket commented Mar 3, 2020

@dotty-bot check CLA

@OlivierBlanvillain
Copy link
Contributor

OlivierBlanvillain commented Mar 4, 2020

The link appears to be broken (the page moved to https://dotty.epfl.ch/docs/reference/other-new-features/kind-polymorphism.html). Could you maybe get rid of the link and remove the Potentially unsound part of the description?

@ybasket
Copy link
Contributor Author

ybasket commented Mar 4, 2020

The link appears to be broken (the page moved to https://dotty.epfl.ch/docs/reference/other-new-features/kind-polymorphism.html). Could you maybe get rid of the link and remove the Potentially unsound part of the description?

Both done!

@odersky odersky merged commit 66220a3 into scala:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants