Fix #8427: Disallow SerialVersionUID on a trait #8429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if it's really not meaningful. |
|
It's not meaningful since it literally doesn't do anything (the bytecode is identical). I don't understand why akka would put it there and silence the warning instead of removing the annotation. |
bishabosha
requested changes
Mar 3, 2020
serialVersionUID fields are only meaningful on a class, not an interface, see https://docs.oracle.com/en/java/javase/13/docs/api/java.base/java/io/Serializable.html
smarter
force-pushed
the
serialvuid-trait
branch
from
f14eec9 to
cd5bf83
Compare
bishabosha
approved these changes
Mar 3, 2020
|
cc @patriknw |
|
Could be for historical reasons. Maybe it was mixed in differently in Scala 2.10 or 2.11, or we simply misunderstood if it was of importance to have the annotation on the traits or not and sprinkled it in more places than need. |
giabao
added a commit
to ohze/akka
that referenced
this pull request
Mar 21, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Mar 27, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Mar 28, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Mar 28, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Mar 28, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Mar 28, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Mar 30, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Mar 31, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Mar 31, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Apr 2, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Apr 5, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Apr 6, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Apr 7, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Apr 8, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Apr 9, 2020
giabao
added a commit
to ohze/akka
that referenced
this pull request
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.