Explicit types for implicits in tests/untried #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for constructors) to tests/untried/pos
…ied/neg-with-implicits
odersky
added a commit
that referenced
this pull request
Mar 20, 2014
Explicit types for implicits in tests/untried
|
LGTM. |
|
Some tests were rewritten by the migration tool in this commit so that they don't have valid syntax anymore, eg https://github.com/lampepfl/dotty/blob/master/tests/untried/neg/t6574.scala#L7 |
WojciechMazur
pushed a commit
to WojciechMazur/dotty
that referenced
this pull request
Mar 19, 2025
Backport "doc fix, removed repeated use of the word with" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77 and #82.
This PR applies the migration tool to tests/untried to get the following changes:
For tests/untried/pos:
For tests/untried/neg:
(Note that procedure syntax for functions returning Unit was already removed in a previous PR.)
As you can see, explicit types for implicit vals and implicit defs is still missing for tests/untried/neg, because this is (almost) impossible: In order to add explicit types, the typechecker must have succeeded, but for the tests in neg, it has to fail. That's why I just moved the neg tests involving implicits to a separate folder.