Skip to content

Add MUnit to the community build #8236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

gabro
Copy link
Contributor

@gabro gabro commented Feb 7, 2020

Question: should the project be built against Dotty 0.21 or 0.22? MUnit is currently built against 0.21, but there's an open PR that upgrades to 0.22 scalameta/munit#44 MUnit is now built against 0.22

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@gabro
Copy link
Contributor Author

gabro commented Feb 8, 2020

Hmm, the build is failing because the Dotty version is 0.23 but MUnit cross builds to 0.22 (it has some files in scala-0.22). What's the recommended strategy here?

@smarter
Copy link
Member

smarter commented Feb 8, 2020

Change your directory to scala-0 (you might need to tell sbt about that folder)

@gabro
Copy link
Contributor Author

gabro commented Feb 8, 2020

@smarter thanks, makes sense. I'll do it and update the submodule 👍

@gabro gabro force-pushed the munit-community-build branch from 5232216 to 9967dcb Compare February 10, 2020 10:39
@gabro
Copy link
Contributor Author

gabro commented Feb 10, 2020

Unless I'm misinterpreting the logs, I think the CI failure is unrelated. intent tests seem to be failing, while munit tests pass.

@gabro
Copy link
Contributor Author

gabro commented Feb 10, 2020

Ah no, wait. I've updated intent myself by mistake. Sorry about that, I'll fix it

@gabro gabro force-pushed the munit-community-build branch from 9967dcb to 81d05f2 Compare February 10, 2020 11:42
@gabro
Copy link
Contributor Author

gabro commented Feb 10, 2020

🎉 it's working now! /cc @smarter

Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the effort in porting it! All of the Dotty community projects live in forks under the dotty-staging organization – this is so that if we break the community build and need to update the projects, we can do so rapidly. I've created such a fork for MUnit: https://github.com/dotty-staging/munit

Can you point to it from your PR?

@gabro gabro force-pushed the munit-community-build branch from c5d2d2e to 285a447 Compare February 11, 2020 11:50
@gabro
Copy link
Contributor Author

gabro commented Feb 11, 2020

@anatoliykmetyuk sure thing, updated and rebased 👍

@gabro
Copy link
Contributor Author

gabro commented Feb 11, 2020

Ok, now the build is failing because of the recent change to the given syntax. What do you advice I do, @anatoliykmetyuk?

@anatoliykmetyuk
Copy link
Contributor

@gabro I've added you to dotty-staging/munit, so you should be able to update the syntax there and reference the new commit from Dotty submodules.

@gabro
Copy link
Contributor Author

gabro commented Feb 11, 2020

Done 👍

@anatoliykmetyuk anatoliykmetyuk merged commit 5b006fb into scala:master Feb 11, 2020
@gabro gabro deleted the munit-community-build branch February 11, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants