-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add MUnit to the community build #8236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
1d9e35a
to
767ac2d
Compare
Hmm, the build is failing because the Dotty version is 0.23 but MUnit cross builds to 0.22 (it has some files in |
Change your directory to scala-0 (you might need to tell sbt about that folder) |
@smarter thanks, makes sense. I'll do it and update the submodule 👍 |
5232216
to
9967dcb
Compare
Unless I'm misinterpreting the logs, I think the CI failure is unrelated. |
Ah no, wait. I've updated |
9967dcb
to
81d05f2
Compare
🎉 it's working now! /cc @smarter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the effort in porting it! All of the Dotty community projects live in forks under the dotty-staging
organization – this is so that if we break the community build and need to update the projects, we can do so rapidly. I've created such a fork for MUnit: https://github.com/dotty-staging/munit
Can you point to it from your PR?
f6fb60b
to
c5d2d2e
Compare
c5d2d2e
to
285a447
Compare
@anatoliykmetyuk sure thing, updated and rebased 👍 |
Ok, now the build is failing because of the recent change to the given syntax. What do you advice I do, @anatoliykmetyuk? |
@gabro I've added you to dotty-staging/munit, so you should be able to update the syntax there and reference the new commit from Dotty submodules. |
Done 👍 |
Question: should the project be built against Dotty 0.21 or 0.22?
MUnit is currently built against 0.21, but there's an open PR that upgrades to 0.22 scalameta/munit#44MUnit is now built against 0.22