Fix init error in test #8109
Merged
Fix init error in test #8109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
approved these changes
Jan 28, 2020
| @@ -25,12 +25,12 @@ object TypeLevel { | |||
| def mirror(ordinal: Int): Mirror = | |||
| mirror(ordinal, EmptyProduct) | |||
|
|
|||
| val label: Array[Array[String]] = | |||
| initLabels(0, 0, new mutable.ArrayBuffer[String], new mutable.ArrayBuffer[Array[String]]) | |||
|
|
|||
| private final val elemSeparator = '\000' | |||
| private final val caseSeparator = '\001' | |||
There was a problem hiding this comment.
@liufengyun what happens if it is an inline val?
There was a problem hiding this comment.
It should not be an error
There was a problem hiding this comment.
Yes, due to const-fold it's not an error. The checker now runs before const-fold, it thus reports an error.
But I think it's still good to report errors here, as in this case const-fold changes the semantics of programs, which is too subtle for end users.
Note: due to const-fold, the code does not misbehave at runtime. However, it's still good to report errors here, as in this case const-fold changes the semantics of programs, which is too subtle for end users. The field `elemSeparator` and `caseSeparator` are used before they are initialized. -- Error: tests/run/typeclass-derivation2a.scala:31:22 ------------------------- 31 | private final val elemSeparator = '\000' | ^ |Access non-initialized field value elemSeparator. Calling trace: | -> initLabels(0, 0, new mutable.ArrayBuffer[String], new mutable.ArrayBuffer[Array[String]]) [ typeclass-derivation2a.scala:29 ] | -> else if (labelsStr(cur) == elemSeparator) [ typeclass-derivation2a.scala:43 ] -- Error: tests/run/typeclass-derivation2a.scala:32:22 ------------------------- 32 | private final val caseSeparator = '\001' | ^ |Access non-initialized field value caseSeparator. Calling trace: | -> initLabels(0, 0, new mutable.ArrayBuffer[String], new mutable.ArrayBuffer[Array[String]]) [ typeclass-derivation2a.scala:29 ] | -> else if (labelsStr(cur) == caseSeparator) [ typeclass-derivation2a.scala:41 ] 2 errors found
```Scala -- Error: tests/run/tuples1.scala:28:27 ---------------------------------------- 28 | val c0_1 = x0 ++ x1; val c0_1c: Int *: Unit = c0_1c; println(s"c0_1 = $c0_1") | ^ |Access non-initialized field value c0_1c. Calling trace: | -> val c0_1 = x0 ++ x1; val c0_1c: Int *: Unit = c0_1c; println(s"c0_1 = $c0_1") [ tuples1.scala:28 ] -- Error: tests/run/tuples1.scala:29:27 ---------------------------------------- 29 | val c1_0 = x1 ++ x0; val c1_0c: Int *: Unit = c1_0c; println(s"c1_0 = $c1_0") | ^ |Access non-initialized field value c1_0c. Calling trace: | -> val c1_0 = x1 ++ x0; val c1_0c: Int *: Unit = c1_0c; println(s"c1_0 = $c1_0") [ tuples1.scala:29 ] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field
elemSeparatorandcaseSeparatorare used before they are initialized.