Fix #7748: Don't allow case classes to be defined in universal traits #7772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
changed the title
smarter
requested changes
Dec 16, 2019
| @@ -1810,6 +1810,10 @@ class Typer extends Namer | |||
| // check value class constraints | |||
| checkDerivedValueClass(cls, body1) | |||
|
|
|||
| val effectiveOwner = cls.owner.skipWeakOwner | |||
| if cls.is(CaseClass) && effectiveOwner.is(Trait) && !effectiveOwner.derivesFrom(defn.ObjectClass) | |||
There was a problem hiding this comment.
I think the previous version of this check was closer to being correct: defining a class or an object in a value class is disallowed, so we should similarly disallow them in universal traits. There was one build failure because the universal trait SeqOps in the standard library defines some private inner classes, which I think is fine as long as we infer that those are private[this] classes:
Suggested change
| if cls.is(CaseClass) && effectiveOwner.is(Trait) && !effectiveOwner.derivesFrom(defn.ObjectClass) | |
| if !cls.isRefinementClass && cls.isAllOf(PrivateLocal) && effectiveOwner.is(Trait) && | |
| !effectiveOwner.derivesFrom(defn.ObjectClass) | |
| then |
smarter
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.