Fix #7677: Fix comparisons involving NaN #7693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the fix in 10cc2f8 which was apparently incomplete since it doesn't handle i7677.scala correctly and replace it by the original fix done in scalac in scala/scala#5207. (It might have been possible to fix the dotty version instead, but I'd rather keep the dotty backend as close as possible to the scalac backend). Since this commit contains code from scalac it is: Co-Authored-By: Lukas Rytz <lukas.rytz@gmail.com>
smarter
force-pushed
the
nan-comparisons
branch
from
c6c1c89 to
2e429e0
Compare
nicolasstucki
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the fix in 10cc2f8 which
was apparently incomplete since it doesn't handle i7677.scala correctly
and replace it by the original fix done in scalac in
scala/scala#5207. (It might have been possible
to fix the dotty version instead, but I'd rather keep the dotty backend
as close as possible to the scalac backend).
Since this commit contains code from scalac it is:
Co-Authored-By: Lukas Rytz lukas.rytz@gmail.com