Skip to content

Update TASTy Reflect to summon and given #7687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Dec 5, 2019
@nicolasstucki nicolasstucki force-pushed the update-tasty-reflect-to-summon-and-given branch from 4cbced0 to 506bb4c Compare December 5, 2019 17:59
@nicolasstucki nicolasstucki marked this pull request as ready for review December 6, 2019 06:11
@nicolasstucki
Copy link
Contributor Author

@milessabin this PR contains a small change in the Shapeless macros.

@milessabin
Copy link
Contributor

@nicolasstucki thanks for the heads up!

@nicolasstucki nicolasstucki added this to the 0.21 Tech Preview milestone Dec 12, 2019
@nicolasstucki nicolasstucki force-pushed the update-tasty-reflect-to-summon-and-given branch from 09dec99 to 1e397e0 Compare December 12, 2019 12:49
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki
Copy link
Contributor Author

I removed the changes from Shapeless.

@nicolasstucki nicolasstucki merged commit 19e7a28 into scala:master Dec 12, 2019
@nicolasstucki nicolasstucki deleted the update-tasty-reflect-to-summon-and-given branch December 12, 2019 13:33
@milessabin
Copy link
Contributor

I removed the changes from Shapeless.

Slightly confused ... have you left the old API for backwards compatibility?

@nicolasstucki
Copy link
Contributor Author

I left the old API for the TASTy reflect part for now. I only updated the quoted expressions API

@milessabin
Copy link
Contributor

Ahh ... right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants