Skip to content

Tastydoc update #7686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 13, 2019
Merged

Tastydoc update #7686

merged 10 commits into from
Dec 13, 2019

Conversation

abgruszecki
Copy link
Contributor

Update Tastydoc so that it compiles again.

See #7668.

Remaining work: update collections to 2.13, update tasty.reflect usages in places where a bit of thinking is necessary (NOTE comments)

@nicolasstucki
Copy link
Contributor

@AleksanderBG now it compiles. I did not try the tests.

@abgruszecki
Copy link
Contributor Author

I generated the test documentation and there's definitely something wrong with the changes. Many links are broken. Seems some packages are treated as objects, probably we borked something when adjusting the SymRef code.

@bishabosha
Copy link
Member

its still using the old syntax for givens e.g.

[error] -- [E019] Syntax Error: /Users/jamie/workspace/dotty/tastydoc/src/dotty/tastydoc/TastyExtractor.scala:61:153 
[error] 61 |  def extractClassMembers(reflect: Reflection)(body: List[reflect.Statement], symbol: reflect.ClassDefSymbol, parentRepresentation: Some[Representation]) given (mutablePackagesMap: scala.collection.mutable.HashMap[String, EmulatedPackageRepresentation]) : List[Representation with Modifiers] = {

@abgruszecki
Copy link
Contributor Author

@bishabosha tastydoc compiles on this branch for me, have you pulled all the changes?

@bishabosha
Copy link
Member

@AleksanderBG Sorry, I should have checked the commits here before commenting ha

@abgruszecki abgruszecki marked this pull request as ready for review December 13, 2019 12:11
@abgruszecki abgruszecki merged commit 68d09ac into scala:master Dec 13, 2019
@abgruszecki abgruszecki deleted the tastydoc-update branch December 13, 2019 12:12
@abgruszecki
Copy link
Contributor Author

Apparently having tastydoc not compile breaks launchIDE, so I'm merging this PR into master. We'll worry about making Tastydoc work properly later on.

This was referenced Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants