-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Tastydoc update #7686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tastydoc update #7686
Conversation
@AleksanderBG now it compiles. I did not try the tests. |
I generated the test documentation and there's definitely something wrong with the changes. Many links are broken. Seems some packages are treated as objects, probably we borked something when adjusting the |
its still using the old syntax for givens e.g. [error] -- [E019] Syntax Error: /Users/jamie/workspace/dotty/tastydoc/src/dotty/tastydoc/TastyExtractor.scala:61:153
[error] 61 | def extractClassMembers(reflect: Reflection)(body: List[reflect.Statement], symbol: reflect.ClassDefSymbol, parentRepresentation: Some[Representation]) given (mutablePackagesMap: scala.collection.mutable.HashMap[String, EmulatedPackageRepresentation]) : List[Representation with Modifiers] = { |
@bishabosha tastydoc compiles on this branch for me, have you pulled all the changes? |
@AleksanderBG Sorry, I should have checked the commits here before commenting ha |
Apparently having |
Update Tastydoc so that it compiles again.
See #7668.
Remaining work: update collections to 2.13, update tasty.reflect usages in places where a bit of thinking is necessary (
NOTE
comments)