Fix #7669: Implement extended with syntax for extension methods.
#7670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Break out optional `with` from TemplateBody production
- Disallow `new with { ...}`.
We don't actually solve this one. `given` still applies to all parameters in a clause.
Don't allow extension methods to have type parameters if collective type parameters were already given. The reason to disallow is that we don't support multiple consecutive type argument sections yet. And merging two type parameter sections into one would break a future extension where we do allow multiple consecutive type argument sections.
So far we allowed `given A, B with ... ` but not `given A with B with ... `
Implement `extended with` syntax for extension methods.
odersky
force-pushed
the
change-extended
branch
from
355cfd7 to
4f62d5f
Compare
odersky
force-pushed
the
change-extended
branch
from
4f62d5f to
f41f4b8
Compare
smarter
reviewed
Dec 3, 2019
| constrApps(commaOK = true, templateCanFollow = true) | ||
| else if in.token == SUBTYPE then | ||
| if !mods.is(Inline) then | ||
| syntaxError("`<:' is only allowed for given with `inline' modifier") |
There was a problem hiding this comment.
Use `<:` instead of `<:' (same with inline) ? Both conventions seem to be used in the parser, but markdown-like syntax is probably more user-friendly.
There was a problem hiding this comment.
Let's discuss which one to use and then standardize. I'll open an issue.
smarter
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #7657