Skip to content

Add tests for the current tuple API #7633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2019
Merged

Add tests for the current tuple API #7633

merged 2 commits into from
Dec 1, 2019

Conversation

brunnerant
Copy link
Contributor

This pull request adds tests for all non-trivial methods in the current tuple API, defined in library/src/scala/Tuple.scala.

See @nicolasstucki, my project supervisor, for more questions.

dottybot
dottybot reviewed Nov 27, 2019
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@brunnerant
Copy link
Contributor Author

brunnerant commented Nov 27, 2019 •
edited
Loading

I made a small bugfix in DynamicTuple.dynamicMap that was discovered by the tests that I wrote.

@nicolasstucki nicolasstucki merged commit eeb0925 into scala:master Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunnerant @nicolasstucki @dottybot