Add ujson and the scalatest-scalacheck bridge to the community build #7632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we do not get NullPointerExceptions when a dependency of a project is defined after the project in question.
So that the correct Dotty version ends up in scope
anatoliykmetyuk
changed the title
liufengyun
approved these changes
Nov 28, 2019
| sbtTestCommand = "scalatestPlusScalaCheckJVM/compile", // TODO: compile only because tests are prone to java.lang.OutOfMemoryError: Metaspace | ||
| sbtUpdateCommand = "scalatestPlusScalaCheckJVM/update", | ||
| sbtPublishCommand = "scalatestPlusScalaCheckJVM/publishLocal", | ||
| dependencies = List(scalatest, scalacheck) |
There was a problem hiding this comment.
The dependency on scalatest and scalacheck is not effective, if the versions don't match in dependency specification.
There was a problem hiding this comment.
It should be fine FTTB. Assuming that specifying the correct dependency is the responsibility of the one adding a new project to the build, and that these custom dependencies are local, the test would just fail to resolve the dependencies if they are misspecified in any of the concerned projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.