Upgrade to Scala.js 1.0.0-RC1. #7617

sjrd · 2019-11-26T12:38:34Z

There were several changes to the IR in 1.0.0-RC1 that have an impact on this codebase:

Primitive types now have dedicated PrimRefs when used as TypeRefs, so for example IntRef instead of ClassRef("I").
See Use a dedicated PrimRef for TypeRefs of primitive types. scala-js/scala-js#3802
Names now have dedicated types instead of Strings, and depend on the kind of symbol: LocalName, LabelName, FieldName, MethodName and ClassName. There are different kinds of js.Idents to go with each kind of Name.
See Introduce dedicated types for the kinds of Idents and their Names. scala-js/scala-js#3804, Fix #2108: Defer identifier name mangling to the emitter. scala-js/scala-js#3814 and Cleanups after the big Name refactoring scala-js/scala-js#3833
Original names are now represented by a dedicated OriginalName type, and they are stored only at definition site, not at use site.
See Fix #3827: Review original names scala-js/scala-js#3845

dottybot

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

Separate subject from body with a blank line

When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:

Limit the subject line to 72 characters

Capitalize the subject line

Do not end the subject line with a period

Use the imperative mood in the subject line ("Add" instead of "Added")

Wrap the body at 80 characters

Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

sjrd · 2019-11-26T12:39:13Z

project/Build.scala

@@ -970,9 +970,9 @@ object Build {
            -- "CollectionTest.scala" -- "CollectionsOnCheckedCollectionTest.scala" -- "CollectionsOnCheckedListTest.scala" -- "CollectionsOnCheckedMapTest.scala" -- "CollectionsOnCheckedSetTest.scala"
            -- "CollectionsOnCollectionsTest.scala" -- "CollectionsOnListsTest.scala" -- "CollectionsOnMapsTest.scala" -- "CollectionsOnSetFromMapTest.scala" -- "CollectionsOnSetsTest.scala"
            -- "CollectionsOnSynchronizedCollectionTest.scala" -- "CollectionsOnSynchronizedListTest.scala" -- "CollectionsOnSynchronizedMapTest.scala" -- "CollectionsOnSynchronizedSetTest.scala" -- "CollectionsTest.scala"
-            -- "DequeTest.scala" -- "EventObjectTest.scala" -- "FormatterTest.scala" -- "HashMapTest.scala" -- "HashSetTest.scala"
+            -- "DequeTest.scala" -- "EventObjectTest.scala" -- "FormatterTest.scala" -- "HashMapTest.scala" -- "HashSetTest.scala" -- "IdentityHashMapTest.scala"


This file was added in 1.0.0-RC1. Like the other collection tests, it doesn't pass.

sjrd · 2019-11-26T12:39:25Z

project/Build.scala

            -- "LinkedHashMapTest.scala" -- "LinkedHashSetTest.scala" -- "LinkedListTest.scala" -- "ListTest.scala" -- "MapTest.scala"
-            -- "NavigableSetTest.scala" -- "SetTest.scala" -- "SortedMapTest.scala" -- "SortedSetTest.scala" -- "TreeSetTest.scala")).get
+            -- "NavigableSetTest.scala" -- "PriorityQueueTest.scala" -- "SetTest.scala" -- "SortedMapTest.scala" -- "SortedSetTest.scala" -- "TreeSetTest.scala")).get


This file was added in 1.0.0-RC1. Like the other collection tests, it doesn't pass.

sjrd · 2019-11-26T12:40:32Z

project/Build.scala

@@ -958,7 +958,7 @@ object Build {
        (
          (dir / "shared/src/test/scala/org/scalajs/testsuite/compiler" ** (("*.scala":FileFilter) -- "RegressionTest.scala" -- "ReflectiveCallTest.scala")).get
          ++ (dir / "shared/src/test/scala/org/scalajs/testsuite/javalib/lang" ** (("*.scala": FileFilter) -- "StringTest.scala")).get
-          ++ (dir / "shared/src/test/scala/org/scalajs/testsuite/javalib/io" ** (("*.scala": FileFilter) -- "ByteArrayInputStreamTest.scala" -- "ByteArrayOutputStreamTest.scala" -- "DataInputStreamTest.scala" -- "DataOutputStreamTest.scala" -- "InputStreamTest.scala" -- "OutputStreamWriterTest.scala" -- "PrintStreamTest.scala" -- "CommonStreamsTests.scala")).get
+          ++ (dir / "shared/src/test/scala/org/scalajs/testsuite/javalib/io" ** (("*.scala": FileFilter) -- "ByteArrayInputStreamTest.scala" -- "ByteArrayOutputStreamTest.scala" -- "DataInputStreamTest.scala" -- "DataOutputStreamTest.scala" -- "InputStreamTest.scala" -- "OutputStreamWriterTest.scala" -- "PrintStreamTest.scala" -- "ReadersTest.scala" -- "CommonStreamsTests.scala")).get


The tests in ReadersTest.scala have changed, and now include calls like

assertEquals(5, someLong())

which dotty resolves to calling assertEquals(Any, Any) (and the int compares as not equal to the Long) whereas Scala 2 resolves to calling assertEquals(Long, Long).

Would you mind opening an issue for that ?

Yeah, I'll minimize it later today.

smarter

LGTM, thanks for the detailed breakdown!

sjrd · 2019-11-26T15:32:31Z

It looks like I'm hitting spurious reentrant checks:

possible data race involving globally reachable variable table in class ConcurrentHashMap: Array[java.util.concurrent.ConcurrentHashMap.Node[K, V]]
  use -Ylog:checkReentrant+ to find out more about why the variable is reachable.
possible data race involving globally reachable variable keySet in class AbstractMap: java.util.Set[K]
  use -Ylog:checkReentrant+ to find out more about why the variable is reachable.
possible data race involving globally reachable variable values in class AbstractMap: java.util.Collection[V]
  use -Ylog:checkReentrant+ to find out more about why the variable is reachable.
possible data race involving globally reachable variable root in class Pattern: java.util.regex.Pattern.Node
  use -Ylog:checkReentrant+ to find out more about why the variable is reachable.
possible data race involving globally reachable variable matchRoot in class Pattern: java.util.regex.Pattern.Node
  use -Ylog:checkReentrant+ to find out more about why the variable is reachable.
possible data race involving globally reachable variable buffer in class Pattern: Array[Int]
  use -Ylog:checkReentrant+ to find out more about why the variable is reachable.
possible data race involving globally reachable variable namedGroups in class Pattern: java.util.Map[String, Integer]
  use -Ylog:checkReentrant+ to find out more about why the variable is reachable.
possible data race involving globally reachable variable groupNodes in class Pattern: Array[java.util.regex.Pattern.GroupHead]
  use -Ylog:checkReentrant+ to find out more about why the variable is reachable.
possible data race involving globally reachable variable capturingGroupCount in class Pattern: Int
  use -Ylog:checkReentrant+ to find out more about why the variable is reachable.
possible data race involving globally reachable variable localCount in class Pattern: Int
  use -Ylog:checkReentrant+ to find out more about why the variable is reachable.
10 errors found

but trying to use -Ylog:checkReentrant+ with the reproduction stored in the logs doesn't give any more details. I just see those 10 errors, and no additional information.

There were several changes to the IR in 1.0.0-RC1 that have an impact on this codebase: * Primitive types now have dedicated `PrimRef`s when used as `TypeRef`s, so for example `IntRef` instead of `ClassRef("I")`. See scala-js/scala-js#3802 * Names now have dedicated types instead of `String`s, and depend on the kind of symbol: `LocalName`, `LabelName`, `FieldName`, `MethodName` and `ClassName`. There are different kinds of `js.Ident`s to go with each kind of `Name`. See scala-js/scala-js#3804, scala-js/scala-js#3814 and scala-js/scala-js#3833 * Original names are now represented by a dedicated `OriginalName` type, and they are stored only at definition site, not at use site. See scala-js/scala-js#3845

sjrd requested a review from nicolasstucki November 26, 2019 12:38

dottybot reviewed Nov 26, 2019

View reviewed changes

sjrd commented Nov 26, 2019

View reviewed changes

smarter approved these changes Nov 26, 2019

View reviewed changes

sjrd force-pushed the scalajs-1.0.0-RC1 branch from 980d37b to 0c8b7aa Compare November 26, 2019 16:03

sjrd mentioned this pull request Nov 26, 2019

Drone CI fails os-lib #7621

Closed

smarter merged commit 28f3da6 into scala:master Nov 27, 2019

smarter deleted the scalajs-1.0.0-RC1 branch November 27, 2019 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade to Scala.js 1.0.0-RC1. #7617

Upgrade to Scala.js 1.0.0-RC1. #7617

sjrd commented Nov 26, 2019

Uh oh!

dottybot left a comment

Uh oh!

sjrd Nov 26, 2019

Uh oh!

sjrd Nov 26, 2019

Uh oh!

sjrd Nov 26, 2019

Uh oh!

smarter Nov 26, 2019

Uh oh!

sjrd Nov 26, 2019

Uh oh!

smarter left a comment

Uh oh!

sjrd commented Nov 26, 2019

Uh oh!

Uh oh!

Upgrade to Scala.js 1.0.0-RC1. #7617

Upgrade to Scala.js 1.0.0-RC1. #7617

Conversation

sjrd commented Nov 26, 2019

Uh oh!

dottybot left a comment

Choose a reason for hiding this comment

Commit Messages

Uh oh!

sjrd Nov 26, 2019

Choose a reason for hiding this comment

Uh oh!

sjrd Nov 26, 2019

Choose a reason for hiding this comment

Uh oh!

sjrd Nov 26, 2019

Choose a reason for hiding this comment

Uh oh!

smarter Nov 26, 2019

Choose a reason for hiding this comment

Uh oh!

sjrd Nov 26, 2019

Choose a reason for hiding this comment

Uh oh!

smarter left a comment

Choose a reason for hiding this comment

Uh oh!

sjrd commented Nov 26, 2019

Uh oh!

Uh oh!