Fix #7264: Propagate prototypes in quoted type patterns #7600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#7264a
branch
from
9734709 to
cce5e02
Compare
odersky
commented
Nov 22, 2019
There was a problem hiding this comment.
Can you try again with the changed version of baseType? ie.
val exprPt = pt.baseType(if quoted.isType then defn.QuotedTypeClass else defn.QuotedExprClass)
I really would like to understand why that does not work, and why the alternative works. Otherwise LGTM.
nicolasstucki
force-pushed
the
fix-#7264a
branch
from
b9a82f2 to
a4df497
Compare
|
Rebased |
nicolasstucki
force-pushed
the
fix-#7264a
branch
from
a4df497 to
6f04d8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.