Skip to content

Add os-lib to the community build #7588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 22, 2019

Conversation

anatoliykmetyuk
Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk commented Nov 20, 2019

So far, Mill does not support generating scaladoc jars from Dotty, the reason being the scaladoc generation class being hardcoded in Mill:

https://github.com/lihaoyi/mill/blob/2b5c2465544e318c225d748a3c73b244978ed98c/scalalib/worker/src/ZincWorkerImpl.scala#L106

Hence in the community build, scaladoc publishing is disabled.

@anatoliykmetyuk anatoliykmetyuk self-assigned this Nov 20, 2019
@anatoliykmetyuk anatoliykmetyuk marked this pull request as ready for review November 21, 2019 15:53
@anatoliykmetyuk
Copy link
Contributor Author

This PR also refactors the community build to support the dependencies between projects. So far only Mill libs are interdependent, the SBT libs are not, although it should be easy to support these as well with the current setup.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. very nice work 👍

@anatoliykmetyuk anatoliykmetyuk merged commit d6b1762 into scala:master Nov 22, 2019
@anatoliykmetyuk anatoliykmetyuk deleted the oslib-community branch November 22, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants